Remove need for platform overrides in SafeAreaView.js #38601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47734944 |
|
@Saadnajmi / @acoates-ms > looks good? |
Looks good to me. A few notes:
LGTM from me =) |
|
This pull request was exported from Phabricator. Differential Revision: D47734944 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebook#38601 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/SafeAreaView/SafeAreaView.js#L28-L33 - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/SafeAreaView/SafeAreaView.windows.js#L30-L36 The change here removes the need of forking this file Changelog: [General] [Fixed] - [SafeAreaView] Remove need for platform overrides in SafeAreaView.js Differential Revision: D47734944 fbshipit-source-id: 5726f357182c9f54807bb5a63bbf535e4dcda3fd
christophpurrer
force-pushed
the
export-D47734944
branch
from
8c6a264 to
597833a
Compare
|
@Saadnajmi > Ideally with this (and other changes to come) we would aim to limit the number of forked files 'out of tree platforms' have to maintain. However for the macOS use case you mentioned you might still need one for the foreseeable future |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebook#38601 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/SafeAreaView/SafeAreaView.js#L28-L33 - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/SafeAreaView/SafeAreaView.windows.js#L30-L36 The change here removes the need of forking this file Changelog: [General] [Fixed] - [SafeAreaView] Remove need for platform overrides in SafeAreaView.js Differential Revision: D47734944 fbshipit-source-id: cb9627b618582b4389d7b2870747e712e8d19e86
christophpurrer
force-pushed
the
export-D47734944
branch
from
597833a to
4788bff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47734944 |
Base commit: e64756a |
Summary: Pull Request resolved: facebook#38601 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/SafeAreaView/SafeAreaView.js#L28-L33 - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/SafeAreaView/SafeAreaView.windows.js#L30-L36 The change here removes the need of forking this file Changelog: [General] [Fixed] - [SafeAreaView] Remove need for platform overrides in SafeAreaView.js Reviewed By: NickGerleman Differential Revision: D47734944 fbshipit-source-id: 27ba3399339c90c9b324c77b178407488d7fe18e
christophpurrer
force-pushed
the
export-D47734944
branch
from
4788bff to
e1465c4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47734944 |
|
This pull request has been merged in 80f531f. |
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38601 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/SafeAreaView/SafeAreaView.js#L28-L33 - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/SafeAreaView/SafeAreaView.windows.js#L30-L36 The change here removes the need of forking this file Changelog: [General] [Fixed] - [SafeAreaView] Remove need for platform overrides in SafeAreaView.js Reviewed By: NickGerleman Differential Revision: D47734944 fbshipit-source-id: 84249a3b3e7e3807b3d5ee4bfa4b1cb140541b8b
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38601 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/SafeAreaView/SafeAreaView.js#L28-L33 - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/SafeAreaView/SafeAreaView.windows.js#L30-L36 The change here removes the need of forking this file Changelog: [General] [Fixed] - [SafeAreaView] Remove need for platform overrides in SafeAreaView.js Reviewed By: NickGerleman Differential Revision: D47734944 fbshipit-source-id: 84249a3b3e7e3807b3d5ee4bfa4b1cb140541b8b
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38601 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/SafeAreaView/SafeAreaView.js#L28-L33 - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/SafeAreaView/SafeAreaView.windows.js#L30-L36 The change here removes the need of forking this file Changelog: [General] [Fixed] - [SafeAreaView] Remove need for platform overrides in SafeAreaView.js Reviewed By: NickGerleman Differential Revision: D47734944 fbshipit-source-id: 84249a3b3e7e3807b3d5ee4bfa4b1cb140541b8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This file is forked in out of tree platforms as:
The change here removes the need of forking this file
Changelog:
[General] [Fixed] - [SafeAreaView] Remove need for platform overrides in SafeAreaView.js
Differential Revision: D47734944