Remove Ruby 2.7.7 tests from CircleCI #38611
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47715594 |
Summary: Pull Request resolved: facebook#38551 I think we can safely remove the StaticFrameworks tests: the DynamicFrameworks are stricter than the static, so if something works in a dynamic frameworks setup, it will work also in the static framework one. we can safely delete the following tests - test_ios_template-NewArch-Debug-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-NewArch-Debug-WithoutFlipper-JSC-StaticFrameworks - test_ios_template-NewArch-Release-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-NewArch-Release-WithoutFlipper-JSC-StaticFrameworks - test_ios_template-OldArch-Debug-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-OldArch-Debug-WithoutFlipper-JSC-StaticFrameworks - test_ios_template-OldArch-Release-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-OldArch-Release-WithoutFlipper-JSC-StaticFrameworks - test_ios_rntester-NewArch-Hermes-StaticFrameworks - test_ios_rntester-NewArch-JSC-StaticFrameworks - test_ios_rntester-OldArch-Hermes-StaticFrameworks - test_ios_rntester-OldArch-JSC-StaticFrameworks ## Changelog [Internal] - Remove static frameworks tests in CircleCI Reviewed By: dmytrorykun Differential Revision: D47669902 fbshipit-source-id: 50c735caef904a8886b34649dc6a190eff72e68d
Summary: Pull Request resolved: facebook#38611 For Ruby tests, we are already testing the least recent (2.6.10) and the most recent version (3.2.0). Testig on 2.7.7 (a minor greater than 2.6.10) was an over-cautious measure we can safely remove now after few months where we saw that no changes broke this specific version of ruby. ## Changelog: [Internal] - Remove tests on Ruby 2.7.7 Reviewed By: cortinico Differential Revision: D47715594 fbshipit-source-id: 5b4aed454ab70645b4a9fd5d81a728704f3117b1
cipolleschi
force-pushed
the
export-D47715594
branch
from
7a70e25 to
5831002
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47715594 |
Base commit: e64756a |
|
This pull request has been merged in a374fc5. |
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38611 For Ruby tests, we are already testing the least recent (2.6.10) and the most recent version (3.2.0). Testig on 2.7.7 (a minor greater than 2.6.10) was an over-cautious measure we can safely remove now after few months where we saw that no changes broke this specific version of ruby. ## Changelog: [Internal] - Remove tests on Ruby 2.7.7 Reviewed By: cortinico Differential Revision: D47715594 fbshipit-source-id: 854b5e0369f390d8801b72f1231fe6ce30069e09
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38611 For Ruby tests, we are already testing the least recent (2.6.10) and the most recent version (3.2.0). Testig on 2.7.7 (a minor greater than 2.6.10) was an over-cautious measure we can safely remove now after few months where we saw that no changes broke this specific version of ruby. ## Changelog: [Internal] - Remove tests on Ruby 2.7.7 Reviewed By: cortinico Differential Revision: D47715594 fbshipit-source-id: 854b5e0369f390d8801b72f1231fe6ce30069e09
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38611 For Ruby tests, we are already testing the least recent (2.6.10) and the most recent version (3.2.0). Testig on 2.7.7 (a minor greater than 2.6.10) was an over-cautious measure we can safely remove now after few months where we saw that no changes broke this specific version of ruby. ## Changelog: [Internal] - Remove tests on Ruby 2.7.7 Reviewed By: cortinico Differential Revision: D47715594 fbshipit-source-id: 854b5e0369f390d8801b72f1231fe6ce30069e09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For Ruby tests, we are already testing the least recent (2.6.10) and the most recent version (3.2.0).
Testig on 2.7.7 (a minor greater than 2.6.10) was an over-cautious measure we can safely remove now after few months where we saw that no changes broke this specific version of ruby.
Changelog:
[Internal] - Remove tests on Ruby 2.7.7
Reviewed By: cortinico
Differential Revision: D47715594