Add drawerLockMode prop to DrawerLayoutAndroid #5534
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,6 +28,7 @@ var INNERVIEW_REF = 'innerView'; | |||
| var DrawerLayoutValidAttributes = { | |||
| drawerWidth: true, | |||
| drawerPosition: true, | |||
| drawerLockMode: true | |||
|
By analyzing the blame information on this pull request, we identified @mkonicek, @kmagiera and @nicklockwood to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
| @@ -96,6 +98,14 @@ var DrawerLayoutAndroid = React.createClass({ | |||
| */ | |||
| drawerWidth: ReactPropTypes.number, | |||
| /** | |||
| * Specifies the lock mode of the drawer. | |||
There was a problem hiding this comment.
What is a lock mode? Can you add documentation understandable for someone who doesn't know anything about the Android Drawer?
andreasdri
force-pushed
the
drawerlayout-lockmode
branch
from
fc5fee1 to
1f061ba
Compare
|
@andybb updated the pull request. |
| DrawerConsts.DrawerLockMode.Unlocked, | ||
| DrawerConsts.DrawerLockMode.LockedClosed, | ||
| DrawerConsts.DrawerLockMode.LockedOpen | ||
| ]), |
There was a problem hiding this comment.
@nicklockwood was suggesting not to use constants. These could be just strings, e.g. - "open", "closed", "unlocked".
|
@andybb updated the pull request. |
|
@andybb Any updates? |
|
Let's merge this one after fixing the strings. |
|
👍 |
andreasdri
force-pushed
the
drawerlayout-lockmode
branch
from
1f061ba to
ec4724d
Compare
|
@andybb updated the pull request. |
|
@satya164 Done! |
|
@facebook-github-bot shipit |
|
Awesome! |
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary:Closes facebook#5270. Closes facebook#5534 Differential Revision: D2970771 fb-gh-sync-id: 36a814032283df7d4c469964f803b8d20d1b0c93 shipit-source-id: 36a814032283df7d4c469964f803b8d20d1b0c93
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5270.