Added performance timings to DevTools named hooks parsing #22173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
lunaruan
reviewed
Aug 25, 2021
|
|
||
| let potentialReactHookASTNode = null; | ||
| if (originalSourceColumnNumber === 0) { | ||
| // This most likely indicates a source map type like 'cheap-module-source-map' | ||
| // that intentionally drops column numbers for compilation speed in DEV builds. | ||
| // In this case, we can assume there's probably only one hook per line (true in most cases) | ||
| // and just fail if we find more than one match. | ||
| const matchingNodes = hooksFromAST.filter(node => { | ||
| const matchingNodes = hooksFromAST.filter((node, index) => { |
There was a problem hiding this comment.
Is index being used anywhere here?
There was a problem hiding this comment.
Oh. It was initially (when I added some logs) and I just forgot to remove it. Will do.
There was a problem hiding this comment.
did we have a lint rule for unused declarations?
There was a problem hiding this comment.
Yes, generally, but I guess it doesn't apply to function params.
lunaruan
approved these changes
Aug 25, 2021
| @@ -152,12 +169,13 @@ export function getHookName( | |||
| potentialReactHookASTNode = matchingNodes[0]; | |||
| } | |||
| } else { | |||
| potentialReactHookASTNode = hooksFromAST.find(node => { | |||
| potentialReactHookASTNode = hooksFromAST.find((node, index) => { | |||
This can be turned on or off (statically) via a new __PERFORMANCE_PROFILE__ flag in react-devtools-shared/src/constants. For now, it's disabled, but it's useful to turn on when performance profiling.
bvaughn
force-pushed
the
devtools-named-hooks-performance-timing
branch
from
59ca485 to
84d013b
Compare
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be turned on or off (statically) via a new
__PERFORMANCE_PROFILE__flag inreact-devtools-shared/src/constants. For now, it's disabled, but it's useful to turn on when performance profiling.When enabled, the flag will generate measures like: