-
Notifications
You must be signed in to change notification settings - Fork 48.8k
Add isArray in devTools utils #22438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When Sebastian landed this in #21188, he confirmed that the Closure compiler inlines the wrapper function. Unfortunately DevTools doesn't use the same compilation process, and as a result, the wrapper/indirection doesn't get inlined. Maybe longer term, we should look into running Closure compiler over DevTools builds as well– but in the short term, I'm not sure the added benefits from this change are worth the extra wrapper. Maybe we could use a similar approach as |
Yes, I agree, I will do it |
@bvaughn Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 Thanks
I'm not sure why CI isn't properly running on your PR. Each time you push, it looks like only the CLA check and Code Sandbox run. |
Yes, this is exactly my question, maybe CI knows me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine. This change seems safe, and I ran the tests locally on your branch. Not sure why CI is not cooperating.
Also here I replaced
Array.isArray
withisArray
from 'shared' package