[Work Loop] Unify renderRoot{Sync,Concurrent} #27095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two functions used to diverge more but as we've added more
features they've become almost the same. When they were simpler and less
alike, it made sense to have two separate functions, but now I think it
makes more sense to keep them unified and pass a boolean argument for
the few places where they differ.
This is a refactor and it shouldn't affect any behavior, but the code
paths are slightly different so it still carries some risk.
Next I'm going to do the same for perform{Sync,Concurrent}WorkOnRoot and
associated functions, too.
facebook-github-bot
added
CLA Signed
React Core Team
|
Landed in #31029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two functions used to diverge more but as we've added more features they've become almost the same. When they were simpler and less alike, it made sense to have two separate functions, but now I think it makes more sense to keep them unified and pass a boolean argument for the few places where they differ.
This is a refactor and it shouldn't affect any behavior, but the code paths are slightly different so it still carries some risk.
Next I'm going to do the same for perform{Sync,Concurrent}WorkOnRoot and associated functions, too.