[compiler] Playground qol: shared compilation option directives with tests #32012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
mofeiZ
changed the title
josephsavona
approved these changes
Jan 7, 2025
poteto
approved these changes
Jan 7, 2025
| @@ -142,7 +160,7 @@ test('reset button works', async ({page}) => { | |||
| }); | |||
|
|
|||
| TEST_CASE_INPUTS.forEach((t, idx) => | |||
| test(`playground compiles: ${t.name}`, async ({page}) => { | |||
| test.only(`playground compiles: ${t.name}`, async ({page}) => { | |||
There was a problem hiding this comment.
Suggested change
| test.only(`playground compiles: ${t.name}`, async ({page}) => { | |
| test(`playground compiles: ${t.name}`, async ({page}) => { |
There was a problem hiding this comment.
Thanks for the catch!!
I have a bad habit of procrastinating by writing QOL commits, but forgetting to submit them as a PR 🤦♀️ This is actually from ~2 weeks ago
mofeiZ
changed the title
…tests - Adds @compilationMode(all|infer|syntax|annotation) and @panicMode(none) directives. This is now shared with our test infra - Playground still defaults to `infer` mode while tests default to `all` mode - See added fixture tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infermode while tests default toallmode