Skip to content

[playground] Partially revert #32009 #32035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[playground] Partially revert #32009 #32035

merged 1 commit into from
Jan 9, 2025

Conversation

poteto
Copy link
Member

@poteto poteto commented Jan 9, 2025

I had forgotten that our default error reporting threshold was none due to the fact that build pipelines should not throw errors. This resets it back to throwing on all errors which mostly is the same as the eslint plugin.

Closes #32014.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 9, 2025
I had forgotten that our default error reporting threshold was `none` due to the fact that build pipelines should not throw errors. This resets it back to throwing on all errors which mostly is the same as the eslint plugin.

Closes #32014.
@poteto poteto merged commit 8932ca3 into main Jan 9, 2025
18 of 26 checks passed
@poteto poteto deleted the pr32035 branch January 9, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Compiler Bug]: Playground doesn't display compiler violations
2 participants