Skip to content

[forgive] Add code action to remove dependency array #33000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

[forgive] Add code action to remove dependency array #33000

merged 1 commit into from
Apr 24, 2025

Conversation

poteto
Copy link
Member

@poteto poteto commented Apr 24, 2025 •
edited
Loading

Adds a new codeaction event in the compiler and handler in forgive. This allows you to remove a dependency array when you're editing a range that is within an autodep eligible function.

Co-authored-by: Jordan Brown [email protected]

Stack created with Sapling. Best reviewed with ReviewStack.

This was referenced Apr 24, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Apr 24, 2025
poteto added a commit that referenced this pull request Apr 24, 2025
@poteto @jbrown215
[forgive] Log inferEffectDependencies (#32996)
71d0896 
This was missed earlier.


Co-authored-by: Jordan Brown <[email protected]>
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32996).
* #33002
* #33001
* #33000
* #32999
* #32998
* #32997
* __->__ #32996

Co-authored-by: Jordan Brown <[email protected]>
poteto added a commit that referenced this pull request Apr 24, 2025
@poteto @jbrown215
[forgive] Emit AutoDepsDecoration event when inferring effect deps (#…
cd7d236 
…32997)

Emits a new event for decorating inferred effect dependencies.

Co-authored-by: Jordan Brown <[email protected]>
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32997).
* #33002
* #33001
* #33000
* #32999
* #32998
* __->__ #32997
* #32996

---------

Co-authored-by: Jordan Brown <[email protected]>
github-actions bot pushed a commit that referenced this pull request Apr 24, 2025
@poteto
[forgive] Log inferEffectDependencies (#32996)
7d80c9d 
This was missed earlier.

Co-authored-by: Jordan Brown <[email protected]>
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32996).
* #33002
* #33001
* #33000
* #32999
* #32998
* #32997
* __->__ #32996

Co-authored-by: Jordan Brown <[email protected]>

DiffTrain build for [71d0896](71d0896)
github-actions bot pushed a commit that referenced this pull request Apr 24, 2025
@poteto
[forgive] Emit AutoDepsDecoration event when inferring effect deps (#…
4af5ca8 
…32997)

Emits a new event for decorating inferred effect dependencies.

Co-authored-by: Jordan Brown <[email protected]>
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32997).
* #33002
* #33001
* #33000
* #32999
* #32998
* __->__ #32997
* #32996

---------

Co-authored-by: Jordan Brown <[email protected]>

DiffTrain build for [cd7d236](cd7d236)
poteto added a commit that referenced this pull request Apr 24, 2025
@poteto @jbrown215
[forgive] Hacky first pass at adding decorations for inferred deps (#…
e25e8c7 
…32998)

Draws basic decorations for inferred deps on hover.

Co-authored-by: Jordan Brown <[email protected]>
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32998).
* #33002
* #33001
* #33000
* #32999
* __->__ #32998

Co-authored-by: Jordan Brown <[email protected]>
poteto added a commit that referenced this pull request Apr 24, 2025
@poteto @jbrown215
[forgive] Refactor inferred deps (#32999)
7b21c46 
Refactor.

Co-authored-by: Jordan Brown <[email protected]>
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32999).
* #33002
* #33001
* #33000
* __->__ #32999

Co-authored-by: Jordan Brown <[email protected]>
@poteto @jbrown215
[forgive] Add code action to remove dependency array
76a1c61 
Adds a new codeaction event in the compiler and handler in forgive. This allows you to remove a dependency array when you're editing a range that is within an autodep eligible function.

Co-authored-by: Jordan Brown <[email protected]>
@poteto poteto merged commit f765082 into main Apr 24, 2025
19 of 20 checks passed
@poteto poteto deleted the pr33000 branch April 24, 2025 01:31
poteto added a commit that referenced this pull request Apr 24, 2025
@poteto @jbrown215
[forgive] Don't crash if we couldn't compile (#33001)
b75af04 
Compiler shouldn't crash Forgive if it can't compile (eg parse error due
to being mid-typing).

Co-authored-by: Jordan Brown <[email protected]>
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33001).
* #33002
* __->__ #33001
* #33000

---------

Co-authored-by: Jordan Brown <[email protected]>
github-actions bot pushed a commit that referenced this pull request Apr 24, 2025
@poteto
[forgive] Refactor inferred deps (#32999)
b6017b2 
Refactor.

Co-authored-by: Jordan Brown <[email protected]>
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32999).
* #33002
* #33001
* #33000
* __->__ #32999

Co-authored-by: Jordan Brown <[email protected]>

DiffTrain build for [7b21c46](7b21c46)
github-actions bot pushed a commit that referenced this pull request Apr 24, 2025
@poteto
[forgive] Add code action to remove dependency array (#33000)
7eda227 
Adds a new codeaction event in the compiler and handler in forgive. This
allows you to remove a dependency array when you're editing a range that
is within an autodep eligible function.

Co-authored-by: Jordan Brown <[email protected]>
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33000).
* #33002
* #33001
* __->__ #33000

Co-authored-by: Jordan Brown <[email protected]>

DiffTrain build for [f765082](f765082)
@vercel-release-bot vercel-release-bot mentioned this pull request Apr 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poteto @facebook-github-bot