Add safeguarding from resurrected cutoff UDT from previous session #13521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jowlyzhang merged this pull request in 4069afe. |
jowlyzhang
added a commit
that referenced
this pull request
Apr 9, 2025
…13521) Summary: Public APIs like `DB::GetFullHistoryTsLow` and `DB::IncreaseFullHistoryTsLow` have such safeguarding, allowing them to only be invoked when user defined timestamp is enabled. This PR adds safeguarding into related internal APIs in `ColumnFamilyData` to properly handle the case when the UDT feature are toggled. Pull Request resolved: #13521 Test Plan: ./db_with_timestamp_basic_test --gtest_filter="*EnableDisableUDT*" Reviewed By: cbi42 Differential Revision: D72475234 Pulled By: jowlyzhang fbshipit-source-id: 194c07287e3100da95450b04c76552c9d4a86c2d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public APIs like
DB::GetFullHistoryTsLowandDB::IncreaseFullHistoryTsLowhave such safeguarding, allowing them to only be invoked when user defined timestamp is enabled. This PR adds safeguarding into related internal APIs inColumnFamilyDatato properly handle the case when the UDT feature are toggled.Test plan:
./db_with_timestamp_basic_test --gtest_filter="EnableDisableUDT"