cmake CI tests refactor #4406
Merged
cmake CI tests refactor #4406
+412
−257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create new .github/workflows/cmake-tests.yml with all cmake-related jobs - Move cmake-build-and-test-check, cmake-source-directory-with-spaces, and cmake-visual-2022 jobs - Remove cmake tests from dev-short-tests.yml to improve organization - Maintain same trigger conditions and test configurations - Add dedicated concurrency group for cmake tests This separation allows cmake tests to run independently and makes the CI configuration more modular and easier to maintain.
Cyan4973
force-pushed
the
separate-cmake-tests
branch
from
62b0737 to
b922774
Compare
and comment out windows arm64 tests due to unacceptably long queue time
Cyan4973
force-pushed
the
separate-cmake-tests
branch
from
38fb11b to
9c866c9
Compare
should reproduce facebook#4405 and fail
Cyan4973
force-pushed
the
separate-cmake-tests
branch
8 times, most recently
from
646305e to
75abb8b
Compare
|
So far, I've been able to reproduce the issue described in #4405, Specifically, whenever I change the script to fix the @ThomasDevoogdt : so far, I've not been able to have the new |
- Split monolithic 235-line CMakeLists.txt into focused modules - Main file reduced to 78 lines with clear section organization - Created 5 specialized modules: * ZstdVersion.cmake - CMake policies and version management * ZstdOptions.cmake - Build options and platform configuration * ZstdDependencies.cmake - External dependency management * ZstdBuild.cmake - Build targets and validation * ZstdPackage.cmake - Package configuration generation Benefits: - Improved readability and maintainability - Better separation of concerns - Easier debugging and modification - Preserved 100% backward compatibility - All existing build options and targets unchanged The refactored build system passes all tests and maintains identical functionality while being much easier to understand and maintain.
Cyan4973
force-pushed
the
separate-cmake-tests
branch
2 times, most recently
from
d15a83b to
e6c738b
Compare
|
@Cyan4973 I checked your branch: Compilation seems to be fine with the proposed changes. Btw, Buildroot explicitly exports CXX to My fault that I broke something for Windows, but I also can't fix/check anything there, as I don't have access right now to any Windows PC. |
Cyan4973
force-pushed
the
separate-cmake-tests
branch
from
e6c738b to
11838e0
Compare
|
More specifically, the combination that fails now is Windows + Visual + clang-cl |
Cyan4973
force-pushed
the
separate-cmake-tests
branch
2 times, most recently
from
b11377f to
49fe2ec
Compare
Cyan4973
force-pushed
the
separate-cmake-tests
branch
from
72b59f0 to
b6dc292
Compare
by removing processing of resource files in this case
|
OK, all issues seem finally fixed now |
Still fine! |
overkill and leaky to transport a test result just in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmaketests in CIcmakebuild error reported in Recent commit break cmake building on Windows #4405cmakescript for improved readability