Deprecated the coarse onArrowUp et al key handler props on DraftEditor.react to make it possible to produce editor commands from these keys

[steveluscher]

Previously, it was impossible to do this:

function mapKeysToEditorCommands(e) {
  if (mentionsAutocompleteIsOpen) {
    switch (e.keyCode) {
      case Keys.UP:
        return 'MentionsAutocomplete/select-previous';
      case Keys.DOWN:
        return 'MentionsAutocomplete/select-next';
    }
  }
  return getDefaultKeyBinding(e);
}

<DraftEditor
  keyBindingFn={mapKeysToEditorCommands}
  ...
/>

…because we didn't give TAB, ESCAPE, LEFT, UP, RIGHT, or DOWN a chance to produce a command name.

This pull request:

1. deprecates the prop-based key handlers (onUpArrow et al.) and encourages people to move their custom key logic into a keyBindingFn, and
2. lets the named keypresses fall through to the keyBindingFn whenever a prop-based key handler isn't supplied.
3. Updates the homepage and the rich text example.

[facebook-github-bot]

@steveluscher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[sophiebits]

Can you update RichTextEditorUtil.onTab and the rich examples in examples/? Sounds great otherwise.

[facebook-github-bot]

@steveluscher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[steveluscher]

I updated the examples and the homepage, but I wasn't really sure how to update RichUtils.onTab(). I tried to split it into onTabLevelIncrement and onTabLevelDecrement functions that don't rely on the keyboard event, but that makes it really easy to miss a case (eg. you want to preventDefault iff you're at a place in the text that even supports tab indenting). I ended up just leaving it the way it was.

[flarnie]

It's weird that @steveluscher it looks like you did land this, but the PR was not closed by facebook-github-bot.

I'm closing this, if I'm missing something then please open a new PR and we can land it separately.

I also opened an internal task to look into why the PR wasn't closed when the imported change landed on master. T25937659