This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Fix broken id anchor #2095
Closed
Fix broken id anchor #2095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well spotted, thanks @sajadtorkamani! I took the liberty of updating the test plan so that others can verify and learn how to reproduce issues on the website. |
There was a problem hiding this comment.
@claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@claudiopro merged this pull request in eddcc55. |
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: *Before* submitting a pull request, please make sure the following is done... 1. Fork the repo and create your branch from `master`. 2. If you've added code that should be tested, add tests! 3. If you've changed APIs, update the documentation. 4. Ensure that: * The test suite passes (`npm test`) * Your code lints (`npm run lint`) and passes Flow (`npm run flow`) * You have followed the [testing guidelines](https://github.com/facebook/draft-js/wiki/Testing-for-Pull-Requests) 5. If you haven't already, complete the [CLA](https://code.facebook.com/cla). Please use the simple form below as a guideline for describing your pull request. Thanks for contributing to Draft.js! **Summary** Just a small fix :) **Test Plan** 1. Check out draft-js repo 1. Install dependencies with `yarn` 1. Change working directory to the website dir: `cd website` 1. Launch website in development mode: `yarn start` 1. Click the **Docs** link in the header 1. Click the **Learn more about why** link at the bottom of the page 1. Verify the page **Issues and Pitfalls** opens and scrolls to the **Missing Draft.css** heading Pull Request resolved: facebookarchive#2095 Differential Revision: D15821826 Pulled By: claudiopro fbshipit-source-id: 85977433416c7642f477d5709bee70f0795cf313
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary: *Before* submitting a pull request, please make sure the following is done... 1. Fork the repo and create your branch from `master`. 2. If you've added code that should be tested, add tests! 3. If you've changed APIs, update the documentation. 4. Ensure that: * The test suite passes (`npm test`) * Your code lints (`npm run lint`) and passes Flow (`npm run flow`) * You have followed the [testing guidelines](https://github.com/facebook/draft-js/wiki/Testing-for-Pull-Requests) 5. If you haven't already, complete the [CLA](https://code.facebook.com/cla). Please use the simple form below as a guideline for describing your pull request. Thanks for contributing to Draft.js! **Summary** Just a small fix :) **Test Plan** 1. Check out draft-js repo 1. Install dependencies with `yarn` 1. Change working directory to the website dir: `cd website` 1. Launch website in development mode: `yarn start` 1. Click the **Docs** link in the header 1. Click the **Learn more about why** link at the bottom of the page 1. Verify the page **Issues and Pitfalls** opens and scrolls to the **Missing Draft.css** heading Pull Request resolved: facebookarchive#2095 Differential Revision: D15821826 Pulled By: claudiopro fbshipit-source-id: 85977433416c7642f477d5709bee70f0795cf313
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: *Before* submitting a pull request, please make sure the following is done... 1. Fork the repo and create your branch from `master`. 2. If you've added code that should be tested, add tests! 3. If you've changed APIs, update the documentation. 4. Ensure that: * The test suite passes (`npm test`) * Your code lints (`npm run lint`) and passes Flow (`npm run flow`) * You have followed the [testing guidelines](https://github.com/facebook/draft-js/wiki/Testing-for-Pull-Requests) 5. If you haven't already, complete the [CLA](https://code.facebook.com/cla). Please use the simple form below as a guideline for describing your pull request. Thanks for contributing to Draft.js! **Summary** Just a small fix :) **Test Plan** 1. Check out draft-js repo 1. Install dependencies with `yarn` 1. Change working directory to the website dir: `cd website` 1. Launch website in development mode: `yarn start` 1. Click the **Docs** link in the header 1. Click the **Learn more about why** link at the bottom of the page 1. Verify the page **Issues and Pitfalls** opens and scrolls to the **Missing Draft.css** heading Pull Request resolved: facebookarchive/draft-js#2095 Differential Revision: D15821826 Pulled By: claudiopro fbshipit-source-id: 85977433416c7642f477d5709bee70f0795cf313
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
master.npm test)npm run lint) and passes Flow (npm run flow)Please use the simple form below as a guideline for describing your pull request.
Thanks for contributing to Draft.js!
Summary
Just a small fix :)
Test Plan
yarncd websiteyarn start