Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Fixes HTML importer to make image entity immutable #2184

Closed
wants to merge 3 commits into from
Closed

Fixes HTML importer to make image entity immutable #2184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
796b4a3
Fixes HTML importer to make image entity immutable
Sep 19, 2019
8e89f03
Fixes missing flow annotation
Sep 19, 2019
d1fc7e1
Adds babel/plugin-proposal-optional-chaining dependency
Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"plugins": ["@babel/plugin-proposal-nullish-coalescing-operator"]
"plugins": ["@babel/plugin-proposal-nullish-coalescing-operator", "@babel/plugin-proposal-optional-chaining"]
}
2 changes: 1 addition & 1 deletion meta/bundle-size-stats/Draft.js.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion meta/bundle-size-stats/Draft.min.js.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"devDependencies": {
"@babel/core": "^7.3.4",
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.4.4",
"@babel/plugin-proposal-optional-chaining": "^7.6.0",
"babel-eslint": "^8.1.1",
"babel-preset-fbjs": "^3.2.0",
"cross-env": "^5.1.3",
Expand Down
98 changes: 98 additions & 0 deletions src/model/encoding/__tests__/__snapshots__/convertFromHTMLToContentBlocks-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3074,6 +3074,8 @@ exports[`img with data protocol should be correctly parsed 1`] = `"\\ud83d\\udcf

exports[`img with http protocol should have camera emoji content 1`] = `"\\ud83d\\udcf7"`;

exports[`img with https protocol should have camera emoji content 1`] = `"\\ud83d\\udcf7"`;

exports[`img with role presentation should not be rendered 1`] = `Array []`;

exports[`line break should be correctly parsed - multiple <br> in a content block 1`] = `
Expand Down Expand Up @@ -3475,9 +3477,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "blockquote",
},
Expand All @@ -3488,9 +3494,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "blockquote",
},
Expand Down Expand Up @@ -3537,9 +3547,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "unstyled",
},
Expand All @@ -3550,9 +3564,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "unstyled",
},
Expand Down Expand Up @@ -3599,9 +3617,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "atomic",
},
Expand All @@ -3612,9 +3634,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "atomic",
},
Expand Down Expand Up @@ -3661,9 +3687,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "header-one",
},
Expand All @@ -3674,9 +3704,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "header-one",
},
Expand Down Expand Up @@ -3723,9 +3757,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "header-two",
},
Expand All @@ -3736,9 +3774,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "header-two",
},
Expand Down Expand Up @@ -3785,9 +3827,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "header-three",
},
Expand All @@ -3798,9 +3844,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "header-three",
},
Expand Down Expand Up @@ -3847,9 +3897,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "header-four",
},
Expand All @@ -3860,9 +3914,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "header-four",
},
Expand Down Expand Up @@ -3909,9 +3967,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "header-five",
},
Expand All @@ -3922,9 +3984,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "header-five",
},
Expand Down Expand Up @@ -3971,9 +4037,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "header-six",
},
Expand All @@ -3984,9 +4054,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "header-six",
},
Expand Down Expand Up @@ -4033,9 +4107,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "unordered-list-item",
},
Expand All @@ -4046,9 +4124,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "unordered-list-item",
},
Expand Down Expand Up @@ -4095,9 +4177,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "unstyled",
},
Expand All @@ -4108,9 +4194,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "unstyled",
},
Expand Down Expand Up @@ -4157,9 +4247,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key0",
"nextSibling": "key1",
"parent": null,
"prevSibling": null,
"text": "a",
"type": "code-block",
},
Expand All @@ -4170,9 +4264,13 @@ Array [
"style": Array [],
},
],
"children": Array [],
"data": Object {},
"depth": 0,
"key": "key1",
"nextSibling": null,
"parent": null,
"prevSibling": "key0",
"text": "b",
"type": "code-block",
},
Expand Down
Loading