This repository was archived by the owner on Oct 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import rules from Python2 makes this a bad idea
rbgirshick
reviewed
Oct 25, 2018
Thanks for the review @rbgirshick ! I'm performing some full trainings to verify that accuracy is the same. |
Here are the results for training on Mask R-CNN R-50 FPN 1x. Accuracies match the baselines, and it seems that the Python 2 runtime is a bit slower. I've run it twice.
I'm merging this. |
Open
nprasad2021
pushed a commit
to nprasad2021/maskrcnn-benchmark
that referenced
this pull request
Jan 29, 2019
* Add missing __init__.py files * Add packages * Rename logging.py to logger.py Import rules from Python2 makes this a bad idea * Make import_file py2 compatible * list does not have .copy() in py2 * math.log2 does not exist in py2 * Miscellaneous fixes for py2 * Address comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Python 2, and should fix #7
I've successfully run
tools/train.py
andtools/test.py
after these fixes, and training / inference succeeded without errors.I'll run a quick schedule train/test cycle to verify that the numbers match the expected results.