Skip to content
This repository was archived by the owner on Nov 22, 2022. It is now read-only.

FairseqModelEnsemble class #1116

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytext/task/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class Config(NewTask.Config):
] = ClassificationMetricReporter.Config()

def train_single_model(self, train_config, model_id, rank=0, world_size=1):
return self.trainer.train_single_model(
return self.trainer.real_trainers[model_id].train(
self.data.batches(Stage.TRAIN),
self.data.batches(Stage.EVAL),
self.model.models[model_id],
Expand Down
21 changes: 13 additions & 8 deletions pytext/trainers/ensemble_trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,18 @@ class Config(ConfigBase):

@classmethod
def from_config(cls, config: Config, model: torch.nn.Module, *args, **kwargs):
return cls(create_trainer(config.real_trainer, model, *args, **kwargs))
trainers = [
create_trainer(config.real_trainer, m, *args, **kwargs)
for m in model.models
]

def __init__(self, real_trainer):
self.real_trainer = real_trainer
self.optimizer = real_trainer.optimizer
self.test = real_trainer.test
self.train_single_model = real_trainer.train
return cls(trainers)

def __init__(self, real_trainers):
self.real_trainers = real_trainers
self.optimizer = real_trainers[0].optimizer
self.test = real_trainers[0].test
self.train_single_model = real_trainers[0].train

"""
Train and eval ensemble model, each sub model will be trained separately in
Expand Down Expand Up @@ -53,7 +58,7 @@ def __init__(self, real_trainer):
"""

def train(self, train_iter, eval_iter, model, *args, **kwargs):
for m in model.models:
self.train_single_model(train_iter, eval_iter, m, *args, **kwargs)
for (m, t) in zip(model.models, self.real_trainers):
t.train(train_iter, eval_iter, m, *args, **kwargs)
model.merge_sub_models()
return model, None