This repository was archived by the owner on Nov 22, 2022. It is now read-only.
Make PathManager robust to API changes in fvcore #1196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18803124 |
hudeven
added a commit
to hudeven/pytext
that referenced
this pull request
Dec 17, 2019
Summary: Pull Request resolved: facebookresearch#1196 As PathManager APIs in fvcore keep involving(adding more args), we want to have this adapter to 1) be robust to the changes 2) be 100% compatible with Python file I/O APIs Differential Revision: D18803124 fbshipit-source-id: ce57bef2682a195a42aa6376786408708a06adcc
hudeven
force-pushed
the
export-D18803124
branch
from
60618f1 to
40763fd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18803124 |
hudeven
added a commit
to hudeven/pytext
that referenced
this pull request
Dec 17, 2019
Summary: Pull Request resolved: facebookresearch#1196 As PathManager APIs in fvcore keep involving(adding more args), we want to have this adapter to 1) be robust to the changes 2) be 100% compatible with Python file I/O APIs Differential Revision: D18803124 fbshipit-source-id: e9a261651d7d36169a74d964d955090a607d242a
hudeven
force-pushed
the
export-D18803124
branch
from
40763fd to
e293904
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18803124 |
hudeven
added a commit
to hudeven/pytext
that referenced
this pull request
Dec 17, 2019
Summary: Pull Request resolved: facebookresearch#1196 As PathManager APIs in fvcore keep involving(adding more args), we want to have this adapter to 1) be robust to the changes 2) be 100% compatible with Python file I/O APIs Differential Revision: D18803124 fbshipit-source-id: cb1513baa0763b851e759ae3cb647be1576113b8
hudeven
force-pushed
the
export-D18803124
branch
from
e293904 to
5721f20
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18803124 |
Summary: Pull Request resolved: facebookresearch#1196 As PathManager APIs in fvcore keep involving(adding more args), we want to have this adapter to 1) be robust to the changes 2) be 100% compatible with Python file I/O APIs Reviewed By: chenyangyu1988 Differential Revision: D18803124 fbshipit-source-id: 788012547b690816fc252b6140202a2f2004037e
hudeven
force-pushed
the
export-D18803124
branch
from
5721f20 to
0767d82
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18803124 |
|
This pull request has been merged in f2ff2f5. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As PathManager APIs in fvcore keep involving(adding more args), we want to have this adapter to 1) be robust to the changes 2) be 100% compatible with Python file I/O APIs
Differential Revision: D18803124