Skip to content
This repository was archived by the owner on Nov 22, 2022. It is now read-only.

avoid torchscriptify on a ScriptModule #1214

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pytext/data/bert_tensorizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,10 @@ def forward(
return self.tensorize(tokens_2d, segment_labels_2d, seq_lens_1d, positions_2d)

def torchscriptify(self):
# Don't need torchscriptified tokenizer during training
self.tokenizer = self.tokenizer.torchscriptify()
# tokenizer will only be used in Inference, so we hold its torchscriptify
# by end of the training.
if not isinstance(self.tokenizer, torch.jit.ScriptModule):
self.tokenizer = self.tokenizer.torchscriptify()
return super().torchscriptify()


Expand Down
9 changes: 6 additions & 3 deletions pytext/data/test/tensorizers_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -822,16 +822,19 @@ def test_roberta_tensorizer(self):
tokenizer=DoNothingTokenizer(),
vocab=tensorizer.vocab,
max_seq_len=tensorizer.max_seq_len,
).torchscriptify()
)
script_tensorizer_impl = tensorizer_impl.torchscriptify()
per_sentence_tokens = [tensorizer.tokenizer.tokenize(text)]
tokens_2d, segment_labels_2d, seq_lens_1d, positions_2d = zip(
*[tensorizer_impl.numberize(per_sentence_tokens)]
*[script_tensorizer_impl.numberize(per_sentence_tokens)]
)
script_tensors = tensorizer_impl.tensorize(
script_tensors = script_tensorizer_impl.tensorize(
tokens_2d, segment_labels_2d, seq_lens_1d, positions_2d
)
for tensor, expect in zip(script_tensors, expected):
self.assertEqual(tensor.tolist(), expect)
# test it is able to call torchscriptify multiple time
tensorizer_impl.torchscriptify()


class SquadForRobertaTensorizerTest(unittest.TestCase):
Expand Down