Expose Fast_Order_Id/Fast_Order_Item_Uuid to Cart/CartItem GraphQl #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavadi
suggested changes
Apr 1, 2022
There was a problem hiding this comment.
@shaoqiany Just some minor changes to keep it consistent with whole module. Can you please take a look.
| * | ||
| * @package Fast_Checkout | ||
| * @author Fast <[email protected]> | ||
| * @copyright 2021 Copyright Fast AF, Inc., https://www.fast.co/ |
| public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null) | ||
| { | ||
| if (!isset($value['model'])) { | ||
| throw new LocalizedException(__('"model" value should be specified')); |
There was a problem hiding this comment.
Undefined class. Lets add use Magento\Framework\Exception\LocalizedException; under namespaces
| if (!isset($value['model'])) { | ||
| throw new LocalizedException(__('"model" value should be specified')); | ||
| } | ||
| /** @var Quote $cart */ |
There was a problem hiding this comment.
Undefined class. Lets add use Magento\Quote\Model\Quote; under namespace
| use Magento\Framework\GraphQl\Exception\GraphQlInputException; | ||
| use Magento\Framework\GraphQl\Query\ResolverInterface; | ||
| use Magento\Framework\GraphQl\Schema\Type\ResolveInfo; | ||
| use Magento\QuoteGraphQl\Model\Cart\GetCartForUser; |
| namespace Fast\Checkout\Model\Resolver\Cart; | ||
|
|
||
| use Magento\Framework\GraphQl\Config\Element\Field; | ||
| use Magento\Framework\GraphQl\Exception\GraphQlInputException; |
| public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null) | ||
| { | ||
| if (!isset($value['model'])) { | ||
| throw new LocalizedException(__('"model" value should be specified')); |
| if (!isset($value['model'])) { | ||
| throw new LocalizedException(__('"model" value should be specified')); | ||
| } | ||
| /** @var Item $cartItem */ |
There was a problem hiding this comment.
Lets add use Magento\Quote\Model\Quote\Item; under namespace
| namespace Fast\Checkout\Model\Resolver\CartItem; | ||
|
|
||
| use Magento\Framework\GraphQl\Config\Element\Field; | ||
| use Magento\Framework\GraphQl\Exception\GraphQlInputException; |
| $this->httpContext = $httpContext; | ||
| } | ||
|
|
||
| public function aroundResolve( |
There was a problem hiding this comment.
I'd recommend using beforeResolve method here
/**
* @param Interceptor $subject
* @param Field $field
* @param $context
* @param ResolveInfo $info
* @param array|null $value
* @param array|null $args
* @return null
*/
public function beforeResolve(Interceptor $subject, Field $field, $context, ResolveInfo $info, array $value = null, array $args = null)
{
if (isset($args['input']['fast_order_id'])) {
// pass along the fast_order_id, so Plugin/Api/CartManagement can pick it up
$this->httpContext->setValue(self::CONTEXT_FAST_ORDER_ID_KEY, $args['input']['fast_order_id'], null);
}
//since we're not changing any parameters
return null;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following are not done yet: