-
Notifications
You must be signed in to change notification settings - Fork 28
Vulnerability Consumer #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Kafka Producer Boilerplate - Updater Thread while (true) - Basic Parser CVE - Tests to come
- Vulnerability class to encapsulate information - Parsing almost complete
- updated toString Cpe23Uri - run Main to check flow of information - TODO: extend to all years - TODO: implement update functionality
- sends GET requests to vulndb-code API to retrieve method-level details - downloads all JSON feed from NVD up to current year - TODO: implement continuous update functionality
- Partial testing Parser (tbc) - Dependency Injection for Mockito testing facilitation
- Every day the Thread checks for modified and new vulnerabilities - TODO: Speed up retrieval of relevant_files - TODO: Testing Plugin
- Parsing Github patch commits Adding the following extra information: - time it took to fix the vulnerability (requested by SIG) - files changed in the commit - methods affected by the commit - links to exploits (requested by SIG)
- Mongo Connector to monster ghtorrent - Parser for Commits and PRs - Github API support in case ghtorrent fails - Refactor to allow dep. injection - Hiding of credentials
- Better line number detection - Handles created files - Handles deleted files
even if the vulnerability could not be injected in the DB, the statement is still published and saved in the file system
MihhailSokolov
requested changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall everything is good, just have some minor comments
...yzer/vulnerability-consumer/src/main/java/eu/fasten/analyzer/vulnerabilityconsumer/Main.java
Outdated
Show resolved
Hide resolved
...y-consumer/src/main/java/eu/fasten/analyzer/vulnerabilityconsumer/VulnerabilityConsumer.java
Outdated
Show resolved
Hide resolved
...lity-consumer/src/main/java/eu/fasten/analyzer/vulnerabilityconsumer/db/MetadataUtility.java
Outdated
Show resolved
Hide resolved
...lity-consumer/src/main/java/eu/fasten/analyzer/vulnerabilityconsumer/db/MetadataUtility.java
Show resolved
Hide resolved
...lity-consumer/src/main/java/eu/fasten/analyzer/vulnerabilityconsumer/db/MetadataUtility.java
Show resolved
Hide resolved
MihhailSokolov
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vulnerability-consumer is consuming from the
fasten.vulnerability.out
topic and injecting the vulnerability information in the DB.