Skip to content

maint_allowlist not exempt from rate-limit #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaooliveirap opened this issue Aug 4, 2022 · 1 comment
Closed

maint_allowlist not exempt from rate-limit #556

joaooliveirap opened this issue Aug 4, 2022 · 1 comment

Comments

@joaooliveirap
Copy link
Contributor

According to your docs

Following users are exempt from blocking:
IPs defined in var/.maintenance.ip (See Maintenance Mode guide for more details)

var/.maintenance.ip updates acl maint_allowlist but this acl is never used to exempt the ips from getting blocked.
As a result rate limit will return 429 also for IPs that are on the maintenance list.

Open PR #555

@vvuksan
Copy link
Contributor

vvuksan commented Aug 25, 2022

Included in 1.2.186

@vvuksan vvuksan closed this as completed Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants