Skip to content

According to your docs -> https://github.com/fastly/fastly-magento2/b… #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaooliveirap
Copy link
Contributor

@joaooliveirap joaooliveirap commented Aug 4, 2022

According to your docs.

Following users are exempt from blocking:
IPs defined in var/.maintenance.ip (See Maintenance Mode guide for more details)

var/.maintenance.ip updates acl maint_allowlist but this acl is never used to exempt the ips from getting blocked.
As a result rate limit will return 429 also for IPs that are on the maintenance list.

#556

…lob/master/Documentation/Guides/RATE-LIMITING.md

Following users are exempt from blocking:

IPs defined in var/.maintenance.ip (See Maintenance Mode guide for more details)

var/.maintenance.ip updates acl maint_allowlist but this acl is never used to exempt the ips from getting blocked.

As a result rate limit will return 429 also for ips that are on the maintenance list.
@vvuksan vvuksan merged commit 011ff6a into fastly:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants