Enable browser caching of signed assets #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When asset signing is enabled (i.e. when assets are referenced in the front-end with the deployment version in the URL, like `/static/versionXXXXXXX/...`), it is safe to indicate to the browser that it can "forever cache" the assets. We add a `Cache-Control: max-age=31536000` header for that purpose, if we found out that the original URL was signed.
|
It makes sense since these assets are versioned so very long cache times make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion. This could live in the origin configuration too, but unfortunately we would need to remove the rewriting done in
recv.vclif we wanted to do that, so we might as well have the whole configuration of static asset caching live in Fastly.