Skip to content

fix config save - image optimization #476 #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

dpotkoc
Copy link
Contributor

@dpotkoc dpotkoc commented Aug 24, 2021

This closes #476

Previously on every config save, image optimization snippet was updated by Magento.

I implemented logic:
only if config option "Automatic Compression" was changed then Magento will update snippet.

Method for updating image snippet is getting value from this config option "Automatic Compression":

$this->automaticCompressionHelper->updateVclSnippet($automaticCompression);

There is no point to update this vcl snippet in other cases.

Tested on Magento 2.4.2-p2 and 2.3.6-p1.

@vvuksan vvuksan merged commit 880b1dc into fastly:master Aug 25, 2021
@vvuksan
Copy link
Contributor

vvuksan commented Aug 26, 2021

Released as 1.2.165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fastly Config Save Generates new Image Optimization snippet each time
2 participants