fix config save - image optimization #476 #477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #476
Previously on every config save, image optimization snippet was updated by Magento.
I implemented logic:
only if config option "Automatic Compression" was changed then Magento will update snippet.
Method for updating image snippet is getting value from this config option "Automatic Compression":
fastly-magento2/Observer/ConfigurationSave.php
Line 121 in cdf380c
There is no point to update this vcl snippet in other cases.
Tested on Magento 2.4.2-p2 and 2.3.6-p1.