-
Notifications
You must be signed in to change notification settings - Fork 448
RNN support (part 1) #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RNN support (part 1) #521
Conversation
Vivado-only (io_parallel and io_stream)
So right now this crashes on a GRU I tried with because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vloncar looks good from my side! I checked and the embedding layer works and synthesizes as expected in my models. We may want to address @drankincms's issue though.
I added the RF fix from the ongoing port of the RNN branch. There will be more changes in PR2, namely the transposing of weights is moved to the optimizer, in line with the other layers, which in this PR is done in the initializer of Vivado RNN layers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All clear for me
RNN support (part 1)
As discussed before, this is the first stage of the RNN support. The PR includes the support for parsing RNN layers into the IR, as well as the Vivado-specific initialization. The same initialization specific to Quartus backend can be part of the second PR. After this is merged, parts 2 and 3 will add HLS implementations for Vivado and Quartus.