gocode: Change repo from nsf/gocode to mdempsky/gocode #1814
Conversation
|
@rhysd this is definitely something we should take care of. If the maintainer also advices to use something else, I'm all for it. The only concern is that he somehow implies it's "temporary". I don't think it shouldn't be a problem at all of course, just something to be reminded. Let me look into this, I'm curious why there is even a fork and what the reason for that is. I'll merge this afterwards. Thanks @rhysd |
|
Ok this is the GH issue that goes more over why the fork exists: Also the note from the original author is also a sign that makes it for us safe to switch to the new fork:
I think it's safe to switch. The worst is we can switch back. I think it's better for us to choose stable and maintained projects over stalled one for forwards compatibility and maintenance of vim-go. |
|
Let's try this. Thanks @rhysd |
|
Thank you. Please feel free to revert this branch if it causes some troubles. |
nsf/gocode is not working well with Go 1.10. I just encountered it myself again. The author of original gocode also states and recommends the mdempsky/gocode fork over nsf/gocode: https://github.com/nsf/gocode#an-autocompletion-daemon-for-the-go-programming-language We actually [moved once](#1814), but because we didn't removed the obsolote settings, we weren't prepared for issues that were [reported](#1817), and hence [reverted it back](#1823) This PR also removes all settings. The reason is that the new gocode doesn't support settings anymore. The author decided not the support it. * For `autobuild`, this was removed because the author believe it's not worth tackling it inside `gocode`: mdempsky/gocode#13 * For `propose builtins`, this is actually still supported but disabled in the source code, we need to add it back again in the future: mdempsky/gocode@787cfae * For `unimported packages`: this was just removed and I couldn't find upcoming plans for it Going forward this package seems to be more stable and is a better bet. Most important, as I stated nfs/gocode is not 1.10 compatible and the author has no intentions to fix it.
nsf/gocode is not working well with Go 1.10. I just encountered it myself again. The author of original gocode also states and recommends the mdempsky/gocode fork over nsf/gocode: https://github.com/nsf/gocode#an-autocompletion-daemon-for-the-go-programming-language We actually [moved once](#1814), but because we didn't removed the obsolote settings, we weren't prepared for issues that were [reported](#1817), and hence [reverted it back](#1823) This PR also removes all settings. The reason is that the new gocode doesn't support settings anymore. The author decided not the support it. * For `autobuild`, this was removed because the author believe it's not worth tackling it inside `gocode`: mdempsky/gocode#13 * For `propose builtins`, this is actually still supported but disabled in the source code, we need to add it back again in the future: mdempsky/gocode@787cfae * For `unimported packages`: this was just removed and I couldn't find upcoming plans for it Going forward this package seems to be more stable and is a better bet. Most important, as I stated nfs/gocode is not 1.10 compatible and the author has no intentions to fix it.
nsf/gocode is not working well with Go 1.10. I just encountered it myself again. The author of original gocode also states and recommends the mdempsky/gocode fork over nsf/gocode: https://github.com/nsf/gocode#an-autocompletion-daemon-for-the-go-programming-language We actually [moved once](#1814), but because we didn't removed the obsolote settings, we weren't prepared for issues that were [reported](#1817), and hence [reverted it back](#1823) This PR also removes all settings. The reason is that the new gocode doesn't support settings anymore. The author decided not the support it. * For `autobuild`, this was removed because the author believe it's not worth tackling it inside `gocode`: mdempsky/gocode#13 * For `propose builtins`, this is actually still supported but disabled in the source code, we need to add it back again in the future: mdempsky/gocode@787cfae * For `unimported packages`: this was just removed and I couldn't find upcoming plans for it Going forward this package seems to be more stable and is a better bet. Most important, as I stated nfs/gocode is not 1.10 compatible and the author has no intentions to fix it.
Hi,
I noticed that recently nsf/gocode is no longer maintained (please see notice at the top of README). And now mdempsky/gocode is an official active repository of gocode.
So I think vim-go should use the new repository for now. This PR only changes the repository URL in vim-go repository.
Please note that it's not straightforward to change the URL because the new repo only supports Go 1.10+. What do you think, @fatih?