synchronize with gopls on certain events #2210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
force-pushed
the
lsp/synchronization
branch
from
779ec7a to
ffe2a58
Compare
Register files when FileType is set. This will pre-load gopls and cause it to start tracking files before it's otherwise needed. Because gopls will already be loaded, there is less likely to be a delay the first time a user runs a command that needs it.
Notify gopls when buffers have changed. This won't catch all use cases, but it least makes sure that gopls is notified when the the file is changed on disk (e.g. via `:GoFmt`, `:GoRename`, or other actions by the user) and when gopls should consider the file to be closed, because the buffer was deleted.
bhcleek
force-pushed
the
lsp/synchronization
branch
from
ffe2a58 to
c2fc185
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not synchronize pseudo-files with gopls
register files with gopls when FileType is set
Register files when FileType is set. This will pre-load gopls and cause
it to start tracking files before it's otherwise needed. Because gopls
will already be loaded, there is less likely to be a delay the first
time a user runs a command that needs it.
synchronize buffers with gopls
Notify gopls when buffers have changed. This won't catch all use cases,
but it least makes sure that gopls is notified when the the file is
changed on disk (e.g. via
:GoFmt,:GoRename, or other actions by theuser) and when gopls should consider the file to be closed, because the
buffer was deleted.
Fixes #2207