Debug and sanity mode #1069
Merged
Debug and sanity mode #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/DataFrameExt.scala
Show resolved
Hide resolved
|
One suggestion would be to have incremental smaller pull requests, which would be easier to review. It could be broken down into three parts, as described in the description of the pull request. |
rakeshkashyap123
approved these changes
Feb 14, 2023
anirudhagar13
approved these changes
Feb 14, 2023
...r-impl/src/main/scala/com/linkedin/feathr/offline/generation/DataFrameFeatureGenerator.scala
Show resolved
Hide resolved
feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/SparkIOUtils.scala
Show resolved
Hide resolved
feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/DataFrameExt.scala
Show resolved
Hide resolved
bozhonghu
reviewed
Feb 14, 2023
feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/DataFrameExt.scala
Show resolved
Hide resolved
feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeathrUtils.scala
Show resolved
Hide resolved
enya-yx
added
the
safe to test
anirudhagar13
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description