Skip to content

fix: update banner on snap appearing all the time #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

Alphrag
Copy link
Member

@Alphrag Alphrag commented Apr 21, 2025

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Fix the update banner always showing up on the snap version, regardless of wether there was actually a new version.

Motivation and Context

In #2079 some changes were introduced to prevent snap users from trying to update the app by downloading the .deb file. However, a test was added to show the update banner when the user has a snap version, but was missing to check whether the app actually has an update available, which meant this banner was always showing. This PR makes sure this only happen when it should.

Fix #2112.

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@Alphrag Alphrag requested a review from SpecialAro April 21, 2025 23:40
@Alphrag Alphrag force-pushed the fix-snap-always-updatable branch 2 times, most recently from ad91a79 to 0fd789b Compare April 26, 2025 17:31
@Alphrag Alphrag force-pushed the fix-snap-always-updatable branch from 0fd789b to fe67dd9 Compare April 27, 2025 14:30
@Alphrag Alphrag merged commit 59c3f8d into ferdium:develop Apr 27, 2025
8 of 9 checks passed
@Alphrag Alphrag deleted the fix-snap-always-updatable branch April 27, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ferdium Incorrecly reports as out of date
1 participant