fix: update banner on snap appearing all the time #2126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Fix the update banner always showing up on the snap version, regardless of wether there was actually a new version.
Motivation and Context
In #2079 some changes were introduced to prevent snap users from trying to update the app by downloading the
.deb
file. However, a test was added to show the update banner when the user has a snap version, but was missing to check whether the app actually has an update available, which meant this banner was always showing. This PR makes sure this only happen when it should.Fix #2112.
Screenshots
Checklist
pnpm prepare-code
)pnpm test
passesRelease Notes