This repository was archived by the owner on Aug 31, 2022. It is now read-only.
Use PhantomJS 2.x. #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to pull in 764beee - I'll separate them when I can or you can do it 😁 Otherwise, updating outdated deps one by one would be best for us. Just to make sure that we can go back to a specific point if things get out of wack. |
|
Ok, I think I will just rebase 764beee on the current master 👍 Then I'll split out the dependency updates to separate PRs. Was quite wary of |
|
Can I help on this one ? Since Medium/phantomjs#522 we have trouble to download the version |
|
Would it be possible to create a release for this change? Failures when downloading the PhantomJS binary from bitbucket are a pain and this version of PhantomJS has switched to using github. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows directory-colorfy to work with PhantomJS 2.x. I'm not sure if such a change is desirable, let me know if you think it's ok.