FVM specific EVM precompiles #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changes randomness functions to take a raw i64 since this is userspace now - add precompiles: resolve_address, lookup_address, get_actor_code_cid, get_randomness(beacon/chain)
mriise
force-pushed
the
feat/fevm-syscall-precompile
branch
from
717414f to
e307860
Compare
Stebalien
reviewed
Nov 11, 2022
|
|
||
| fn get_actor_code_cid<RT: Runtime>(rt: &RT, input: &[u8]) -> PrecompileResult { | ||
| let id = EthAddress(input[..20].try_into().unwrap()).as_id(); | ||
| if id.is_none() { |
There was a problem hiding this comment.
We should probably just resolve this address for the user.
There was a problem hiding this comment.
we are just grabbing the code CID, its easy enough to call the resolve_address precompile
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #792 +/- ##
==========================================
- Coverage 87.50% 87.03% -0.47%
==========================================
Files 125 125
Lines 22649 22806 +157
==========================================
+ Hits 19818 19850 +32
- Misses 2831 2956 +125
|
…dresses, assert reserved bytes are zeroes
Stebalien
reviewed
Nov 11, 2022
Stebalien
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes filecoin-project/ref-fvm#947
context will be in its own PR