feat(f3): prefetch the power table of every parent tipset #13107
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/f3-power-table-once
branch
from
fbd9463 to
514574b
Compare
Stebalien
force-pushed
the
steb/f3-power-table-prefetch
branch
from
c0e3f56 to
beeebd0
Compare
Given that we lag F3 by 4 epochs, this means we SHOULD already have the appropriate power table in the cache before we try to agree on it. This is very "best effort" and won't be very effective during catch-up. Honestly, the _right_ way to do this is likely to have F3 pre-fetch and queue up future tipsets, but that's more complicated.
Stebalien
force-pushed
the
steb/f3-power-table-prefetch
branch
from
beeebd0 to
40c3ef6
Compare
|
This has a nasty side effect of causing non-useful work while F3 is behind. Pre-fetch will override itself before the work becomes useful. |
|
Hm. I thought our cache was bigger. One option is to only cache so far beyond the last requested tipset but... that defeats the point of doing this in lotus (trying to keep it simple). Given that we already lag F3 by 4 epochs, the right approach is (IMO) to do this prefetching in F3 itself by:
(and fetch power tables in parallel in general). |
|
Yeah, that is my plan. Thanks for the code in any case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we lag F3 by 4 epochs, this means we SHOULD already have the appropriate power table in the cache before we try to agree on it. This is very "best effort" and won't be very effective during catch-up.
Honestly, the right way to do this is likely to have F3 pre-fetch and queue up future tipsets, but that's more complicated.
follows #13106