EVM: Tracking for native precompile hardening

[mriise]

• resolve_address
• lookup_address
• get_actor_type
• get_randomness (dropped)
• call_actor clean up leftovers from CALLACTOR and METHODNUM refactor. builtin-actors#867
  • assert readonly state transitions
  • value passed in call, but not in params and visa versa
  • compare return value with evm CALL of same contract

Being marked "done" includes:

• ensure reverts are done carefully
• ensure known edge cases have comments or are fixed
• documentation is clear
• at least one test expecting a non-revert error (if applicable)

This issue doesn't track all the hardening needed for native precompiles, but it should cover the basic cases as well as some potential edge cases not tracked in other issues.

[maciejwitowski]

@mriise

ensure reverts are done carefully

What do we mean here for read precompiles like resolve_address?

ensure known edge cases have comments or are fixed

Should we have a list here of these "known edge cases" before start to make sure we have a clear understanding?

at least one test expecting a non-revert error (if applicable)

Are these tests also P1 for Carbonado?

[mriise]

What do we mean here for read precompiles like resolve_address?

Ensure that it doesn't revert

Should we have a list here of these "known edge cases"

It's a bit hard to write it down as part of this issue as they usually require context and I haven't gone through and determined what are edge cases. (should probably add "find edge cases")

Are these tests also P1 for Carbonado?

i would say having at least one should be, just to make sure we are getting roughly expected values

[mriise]

oops

[Stebalien]

Closing in favor of:

#1393
#1392
#1391
#1390