Add support for flows inside pattern using const to a url reference + confirm generated arch document renders flow in docify #1374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… confirm generated arch document renders flow in docify
LeighFinegold
requested review from
aidanm3341,
lbulanti-ms,
willosborne,
grahampacker-ms,
jpgough-ms,
rocketstack-matt,
Thels and
a team
as code owners
LeighFinegold
commented
Jun 20, 2025
| output[key] = await Promise.all( | ||
| resolvedDef.prefixItems.map(async (itemDef, idx) => { | ||
| const resolvedItem = await resolveSchema(itemDef, schemaDir); | ||
| if (resolvedItem.const !== undefined) { |
There was a problem hiding this comment.
Doing
if (resolvedItem.const !== undefined) {
return resolvedItem.const;
}over
if (resolvedItem.const) {
return resolvedItem.const;
}Allows support for
{ const: null }
LeighFinegold
commented
Jun 20, 2025
| @@ -26,15 +26,22 @@ describe('Docifier E2E - Real Model and Template', () => { | |||
|
|
|||
| it('generates documentation from the conference-signup.arch.json model', async () => { | |||
|
|
|||
| const docifier = new Docifier('WEBSITE', join(INPUT_DIR, 'conference-signup.arch.json'), NON_SECURE_VERSION_DOC_WEBSITE, new Map<string,string>()); | |||
| //TODO: This test needs manual mapping until flows folder is republished. | |||
There was a problem hiding this comment.
If folks are happy with this PR, then recommend we first just publish the new flows document to S3 and then this will not be needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to calm generate Function
The
instantiateFromPropertiesfunction in theinstantiate.tsfile has been modified with three key changes:1. Added Support for Constant Values in Array Items
This allows support in the pattern like this
2. Updated example on workshop to show generate works as expected and that subsequent docify command will render flow diagram like below