-
Notifications
You must be signed in to change notification settings - Fork 130
fix: decouple UI layout from admin routes #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
==========================================
- Coverage 49.65% 49.62% -0.03%
==========================================
Files 48 48
Lines 1718 1725 +7
Branches 175 176 +1
==========================================
+ Hits 853 856 +3
- Misses 841 845 +4
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@jescalada - can you resolve conflicts and we will get this merged? 👏 |
Sure! As you mentioned in #917, I'll implement the optional check first, then it should be ready to review. 😃 |
Hi @JamieSlome, it should be good to review now! I added the config entry, new |
Fixes #918, along with #917.
This PR aims to make route access more intuitive. All /admin routes have been replaced with /dashboard, and relevant files have been renamed. Actual admin-only routes, such as the list of users, are displayed with the /admin/ prefix. For example: /dashboard/admin/user.
Unit tests execute the same way as before, and E2E tests have been expanded and amended to work with the new setup.
I also changed the login flow to redirect to the repo list (which seems more intuitive than one's profile), and the username update flow to redirect to one's own profile instead of the "user view" admin route (which would error out for non-admins).
Finally, I added a config entry to define what routes have a specific auth requirement. The rules are shown by default but not enabled.
Changelog
proxy.config.json