Skip to content

Added integration test for AutoML #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 13, 2020
Merged

Added integration test for AutoML #477

merged 6 commits into from
Jul 13, 2020

Conversation

ifielker
Copy link
Contributor

Added conditional integration test for AutoML.

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty great. Just a couple of suggestions.

@@ -34,6 +35,11 @@
except ImportError:
_TF_ENABLED = False

try:
from google.cloud import automl_v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged to master, let's also update the .github/workflows/release.yml to install this package, and add the Auto ML resource to the project Kobayashi Maru.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@hiranya911 hiranya911 assigned ifielker and unassigned hiranya911 Jul 13, 2020
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@hiranya911 hiranya911 removed their assignment Jul 13, 2020
@ifielker ifielker merged commit 86d4aec into mlkit-automl Jul 13, 2020
@ifielker ifielker deleted the mlkit-automl2 branch July 13, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants