Performance test for vhost-user-blk #4190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4190 +/- ##
==========================================
- Coverage 82.22% 82.20% -0.03%
==========================================
Files 236 236
Lines 29203 29203
==========================================
- Hits 24013 24007 -6
- Misses 5190 5196 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kalyazin
force-pushed
the
vu_perf
branch
2 times, most recently
from
35ab459 to
6f96450
Compare
roypat
reviewed
Oct 23, 2023
tests/integration_tests/performance/test_block_vhost_user_ab.py
Outdated
Show resolved
Hide resolved
kalyazin
force-pushed
the
vu_perf
branch
2 times, most recently
from
aaff3d6 to
bc13498
Compare
kalyazin
force-pushed
the
vu_perf
branch
2 times, most recently
from
9bea3f1 to
d558c32
Compare
kalyazin
added
the
Status: Awaiting review
roypat
approved these changes
Nov 8, 2023
roypat
requested changes
Nov 8, 2023
So far, FilesystemFile was only creating drives in the default /srv location, which is mounted as tmpfs. Since Qemu vhost-user-blk backend always uses O_DIRECT when opening drive files, it cannot work with files on tmpfs. If the path argument is not provided to the FilesystemFile constructor, the drive file is created with a random name in /tmp. Signed-off-by: Nikita Kalyazin <[email protected]>
Extracted spawn_vhost_user_backend() into util_vhost_user_backend.py as it will be used by multiple test files. Signed-off-by: Nikita Kalyazin <[email protected]>
The test spins the qemu vhost-user-blk backend and runs the same tests as for the virtio block device. It also emits metrics as test_block_vhost_user_performance. Signed-off-by: Nikita Kalyazin <[email protected]>
This is to run vhost-user-blk performance tests along with other performance tests. Signed-off-by: Nikita Kalyazin <[email protected]>
bchalios
approved these changes
Nov 8, 2023
roypat
approved these changes
Nov 8, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds a performance test for the vhost-user-blk device.
Reason
vhost-user-blk device is added in #4170 .
We need to include performance tests for the new device.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
- [ ] If a specific issue led to this PR, this PR closes the issue.- [ ] Any required documentation changes (code and docs) are included in this PR.- [ ] API changes follow the Runbook for Firecracker API changes.- [ ] User-facing changes are mentioned inCHANGELOG.md.- [ ] NewTODOs link to an issue.rust-vmm.