Log API socket creation and API server start + Correct startup time metrics timing #5143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulinx86
force-pushed
the
log_for_server_up
branch
from
0e4dfe0 to
2be73a0
Compare
zulinx86
changed the title
zulinx86
requested review from
xmarcalx,
kalyazin,
pb8o and
Manciukic
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5143 +/- ##
==========================================
- Coverage 83.03% 83.02% -0.01%
==========================================
Files 250 250
Lines 26911 26911
==========================================
- Hits 22345 22344 -1
- Misses 4566 4567 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zulinx86
added
the
Status: Awaiting review
pb8o
reviewed
Apr 7, 2025
zulinx86
force-pushed
the
log_for_server_up
branch
2 times, most recently
from
1af56fd to
16e742f
Compare
roypat
reviewed
Apr 7, 2025
We found such logs useful to debug startup issues. Signed-off-by: Takahiro Itazuri <[email protected]>
api_server.process_startup_time_us and process_startup_time_cpu_us should be reported right after the server starts. Signed-off-by: Takahiro Itazuri <[email protected]>
zulinx86
force-pushed
the
log_for_server_up
branch
from
16e742f to
d9f851f
Compare
bchalios
approved these changes
Apr 7, 2025
roypat
approved these changes
Apr 8, 2025
Manciukic
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
We found such logs useful to debug Firecracker startup issues.
The startup time metrics were recorded before applying seccomp filter and starting the API server.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
[ ] I have updated any relevant documentation (both in code and in the docs)in the PR.
CHANGELOG.md.[ ] If a specific issue led to this PR, this PR closes the issue.[ ] When making API changes, I have followed theRunbook for Firecracker API changes.
integration tests.
[ ] I have linked an issue to every newTODO.rust-vmm.