Skip to content

Fix compilation error on macOS #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Fix compilation error on macOS #977

merged 1 commit into from
Feb 10, 2020

Conversation

tskeith
Copy link
Collaborator

@tskeith tskeith commented Feb 10, 2020

The call to std::min failed to compile with GCC on macOS due to type
inference because std::size_t is long unsigned int but std::int64_t
is long long int.

The call to `std::min` failed to compile with GCC on macOS due to type
inference because `std::size_t` is `long unsigned int` but `std::int64_t`
is `long long int`.
@tskeith tskeith requested a review from klausler February 10, 2020 18:56
Copy link
Collaborator

@klausler klausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the debugging

@tskeith tskeith merged commit 204c67d into master Feb 10, 2020
@tskeith tskeith deleted the tsk-osx-error branch February 10, 2020 19:05
swift-ci pushed a commit to swiftlang/llvm-project that referenced this pull request Apr 9, 2020
The call to `std::min` failed to compile with GCC on macOS due to type
inference because `std::size_t` is `long unsigned int` but `std::int64_t`
is `long long int`.

Original-commit: flang-compiler/f18@c342575
Reviewed-on: flang-compiler/f18#977
swift-ci pushed a commit to swiftlang/llvm-project that referenced this pull request Apr 9, 2020
…/tsk-osx-error

Fix compilation error on macOS

Original-commit: flang-compiler/f18@204c67d
Reviewed-on: flang-compiler/f18#977
mem-frob pushed a commit to draperlaboratory/hope-llvm-project that referenced this pull request Oct 7, 2022
The call to `std::min` failed to compile with GCC on macOS due to type
inference because `std::size_t` is `long unsigned int` but `std::int64_t`
is `long long int`.

Original-commit: flang-compiler/f18@c342575
Reviewed-on: flang-compiler/f18#977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants