Skip to content

Handle null HostID on calendar webhook endpoint #30130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

juan-fdz-hawa
Copy link
Contributor

For 10744

When making a POST request to the calendar/webhook endpoint, do not error out if host record does not exists.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • Manual QA for all new/changed functionality

When making a POST request to calendar/webhook do not error out if host
record does not exists.
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.13%. Comparing base (5a55de8) to head (2205e10).
Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #30130      +/-   ##
==========================================
- Coverage   64.14%   62.13%   -2.01%     
==========================================
  Files        1867     1866       -1     
  Lines      182617   182660      +43     
  Branches     5296     5296              
==========================================
- Hits       117144   113502    -3642     
- Misses      56266    60065    +3799     
+ Partials     9207     9093     -114     
Flag Coverage Δ
backend 62.87% <100.00%> (-2.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juan-fdz-hawa juan-fdz-hawa merged commit 47992b4 into main Jun 23, 2025
39 of 42 checks passed
@juan-fdz-hawa juan-fdz-hawa deleted the juan-10744-calendar-webhook-500 branch June 23, 2025 17:10
sgress454 pushed a commit that referenced this pull request Jun 24, 2025
For 10744

When making a POST request to the calendar/webhook endpoint, do not error out if host record does not exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants