Skip to content

disable uploading EULA in UI when gitops is enabled #30174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

ghernandez345
Copy link
Contributor

Relates to #28143

remove ability to upload a EULA in the UI if gitops is enabled

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • [s] Manual QA for all new/changed functionality

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (36bf6d9) to head (123289b).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #30174   +/-   ##
=======================================
  Coverage   64.14%   64.14%           
=======================================
  Files        1867     1867           
  Lines      182671   182671           
  Branches     5334     5334           
=======================================
  Hits       117175   117175           
  Misses      56283    56283           
  Partials     9213     9213           
Flag Coverage Δ
frontend 53.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghernandez345 ghernandez345 changed the title diable eula when gitops is enabled disable uploading EULA in UI when gitops is enabled Jun 20, 2025
@ghernandez345 ghernandez345 merged commit 34270c2 into main Jun 23, 2025
15 checks passed
@ghernandez345 ghernandez345 deleted the feat-ui-gitops-eula branch June 23, 2025 13:27
sgress454 pushed a commit that referenced this pull request Jun 24, 2025
Relates to #28143

remove ability to upload a EULA in the UI if gitops is enabled

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.
- [s] Manual QA for all new/changed functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants