fix(share_plus): return correct share result on android #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coronon
added a commit
to Coronon/share_plus_example
that referenced
this pull request
Oct 28, 2022
|
The Linux test failed because it got a 404 while installing packages through apt - that should not affect this PR Thank you for re-running the timedout Android integration tests :) |
vbuberen
reviewed
Oct 29, 2022
packages/share_plus/share_plus/android/src/main/kotlin/dev/fluttercommunity/plus/share/Share.kt
Outdated
Show resolved
Hide resolved
...share_plus/android/src/main/kotlin/dev/fluttercommunity/plus/share/SharePlusPendingIntent.kt
Outdated
Show resolved
Hide resolved
vbuberen
reviewed
Oct 29, 2022
...share_plus/android/src/main/kotlin/dev/fluttercommunity/plus/share/SharePlusPendingIntent.kt
Outdated
Show resolved
Hide resolved
|
Thanks for your review! Fixed all points mentioned and updated my example project and all references to it :) PS: I just submitted a PR for the failing Linux test #1305 |
|
LGTM, but I'll have to run this on Monday before merging. |
miquelbeltran
added
Hacktoberfest
I have tested it on Android 10 physical device and emulator of Android 12. Worked well. |
vbuberen
approved these changes
Oct 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
share_plusandroidshareWithResultandshareFilesWithResultimplementations are broken. The returnedShareResult.rawis alwaysnullon successful share. This PR fixes this by usingFLAG_MUTABLEinstead ofFLAG_IMMUTABLE, as pointed out by @aakash-pamnani. This issue was not found when initially implementing theshareWithResultmethods, as theFLAG_IMMUTABLEwas only required by the highest API versions. Back then, a simple warning was emitted that strongly suggested usingFLAG_IMMUTABLE, which seemed to break nothing.This PR now fixes the behavior and ensures that the
FLAG_MUTABLEPendingIntentgiven out may not be abused by moving from an implicit internalIntentto an explicit one. This also reduces mental complexity of the implementation.I also added some more documentation throughout the android implementation.
As always, I provide share_plus_example as a pre-setup example project for this PR.
Related Issues
Fixes #916
Checklist
CHANGELOG.mdnor thepubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).