Skip to content

Commit b414461

Browse files
committed
Use a collection that can hold null values for groupByAttributes
1 parent 2d772c8 commit b414461

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

mod-erm-usage-counter50/src/main/java/org/olf/erm/usage/counter50/converter/dr/DRConverterBase.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import static java.util.stream.Collectors.reducing;
55
import static java.util.stream.Collectors.toList;
66

7+
import java.util.Arrays;
78
import java.util.List;
89
import java.util.Optional;
910
import java.util.function.Function;
@@ -18,7 +19,7 @@ public abstract class DRConverterBase implements Converter<COUNTERDatabaseReport
1819

1920
protected Function<COUNTERDatabaseUsage, List<Object>> getGroupByAttributes() {
2021
return u ->
21-
List.of(
22+
Arrays.asList(
2223
u.getDatabase(), u.getPlatform(), u.getItemID(), u.getPublisher(), u.getPublisherID());
2324
}
2425

mod-erm-usage-counter50/src/main/java/org/olf/erm/usage/counter50/converter/tr/TRConverterBase.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import static java.util.stream.Collectors.reducing;
55
import static java.util.stream.Collectors.toList;
66

7+
import java.util.Arrays;
78
import java.util.List;
89
import java.util.Optional;
910
import java.util.function.Function;
@@ -18,7 +19,8 @@ public abstract class TRConverterBase implements Converter<COUNTERTitleReport> {
1819

1920
protected Function<COUNTERTitleUsage, List<Object>> getGroupByAttributes() {
2021
return u ->
21-
List.of(u.getTitle(), u.getItemID(), u.getPlatform(), u.getPublisher(), u.getPublisherID());
22+
Arrays.asList(
23+
u.getTitle(), u.getItemID(), u.getPlatform(), u.getPublisher(), u.getPublisherID());
2224
}
2325

2426
protected List<COUNTERTitleUsage> createNewReportItems(

mod-erm-usage-counter50/src/main/java/org/olf/erm/usage/counter50/converter/tr/TRJ3Converter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import static java.util.stream.Collectors.toList;
44

5+
import java.util.Arrays;
56
import java.util.List;
67
import java.util.Map;
78
import java.util.function.Function;
@@ -63,7 +64,7 @@ public class TRJ3Converter extends TRConverterBase {
6364
@Override
6465
public Function<COUNTERTitleUsage, List<Object>> getGroupByAttributes() {
6566
return u ->
66-
List.of(
67+
Arrays.asList(
6768
u.getTitle(),
6869
u.getItemID(),
6970
u.getPlatform(),

mod-erm-usage-counter50/src/main/java/org/olf/erm/usage/counter50/converter/tr/TRJ4Converter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import static java.util.stream.Collectors.toList;
44

5+
import java.util.Arrays;
56
import java.util.List;
67
import java.util.Map;
78
import java.util.function.Function;
@@ -63,7 +64,7 @@ public class TRJ4Converter extends TRConverterBase {
6364
@Override
6465
public Function<COUNTERTitleUsage, List<Object>> getGroupByAttributes() {
6566
return u ->
66-
List.of(
67+
Arrays.asList(
6768
u.getTitle(),
6869
u.getItemID(),
6970
u.getPlatform(),

0 commit comments

Comments
 (0)