Skip to content

🚚 switch to @node-rs/crc32 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024
Merged

🚚 switch to @node-rs/crc32 #17

merged 1 commit into from
Feb 9, 2024

Conversation

ctcpip
Copy link
Member

@ctcpip ctcpip commented Jan 19, 2024

resolves #16

# all tests passed
# test finished in 304 ms

Copy link
Member

@gr0uch gr0uch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! however my only reservation is this:

fallback to software implementation when hardware acceleration fails

can you add a software fallback option?

@ctcpip
Copy link
Member Author

ctcpip commented Feb 9, 2024

it falls back to a web assembly binding if a native binding fails:

https://github.com/napi-rs/node-rs/blob/main/packages%2Fcrc32%2Findex.js#L323

which I think should be good for virtually everywhere. what do you think?

@gr0uch gr0uch merged commit a831e67 into fortunejs:master Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fails to run on arm64 architecture
2 participants