Skip to content

feat(forge): script warn if no transactions to broadcast #10384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 28, 2025
Merged

feat(forge): script warn if no transactions to broadcast #10384

merged 10 commits into from
Apr 28, 2025

Conversation

Ayushdubey86
Copy link
Contributor

Hello @grandizzy , this should close #10015

@Ayushdubey86 Ayushdubey86 mentioned this pull request Apr 27, 2025
Closed
2 tasks
grandizzy
grandizzy previously requested changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one nit, also please add a test for this. thank you

@grandizzy grandizzy changed the title Introducing warning if no transactions to broadcast feat(forge): script warn if no transactions to broadcast Apr 28, 2025
@grandizzy grandizzy added T-feature Type: feature C-forge Command: forge labels Apr 28, 2025
@grandizzy grandizzy self-requested a review April 28, 2025 15:52
grandizzy
grandizzy approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, thank you!

@grandizzy grandizzy enabled auto-merge (squash) April 28, 2025 15:53
@grandizzy grandizzy merged commit 1a5ff59 into foundry-rs:master Apr 28, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grandizzy grandizzy grandizzy approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-feature Type: feature
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(forge script): warn if no tx to broadcast when passing --broadcast
2 participants
@Ayushdubey86 @grandizzy