feat(forge): run lint on forge build
#10748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automatic linting during forge build to provide early feedback on Solidity code quality and security issues. Changes: - Add optional linter field to ProjectCompiler with builder method - Run linting before compilation when linter is configured - Respect --quiet flag to suppress linting output - Configure linter from foundry.toml LinterConfig settings - Support JSON output format for linting diagnostics - Add comprehensive tests for build-time linting behavior The linter runs before compilation and uses all settings from the [lint] section in foundry.toml including severity filtering and lint exclusions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
yash-atreya
changed the title
forge): run lint on forge build
Add new boolean config option `lint_on_build` in LinterConfig that allows users to disable automatic linting during `forge build` while maintaining the improved developer experience by default. Changes: - Add `lint_on_build` field to LinterConfig (defaults to true) - Update forge build to check lint_on_build before configuring linter - Add test for lint_on_build = false behavior - Update existing tests to include new config field - Modify can_build_after_failure test to disable linting Users can now disable build-time linting in foundry.toml: ```toml [lint] lint_on_build = false ``` 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The test_default_config was failing after adding the lint_on_build property to LintConfig. Updated the expected output snapshots to include the new property with its default value of true. - Updated TOML format snapshot to include `lint_on_build = true` in [lint] section - Updated JSON format snapshot to include `"lint_on_build": true` in lint object 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates the SolidityLinter into the forge build command to provide automatic linting feedback
before compilation. This is similar to how
cargosuggests lints oncargo build.Changes
Core Integration
Implementation Details
Test Coverage
Added comprehensive tests in crates/forge/tests/cli/lint.rs:
🤖 Generated with https://claude.ai/code
PR Checklist