fix: nix CI build #10760
Merged
fix: nix CI build #10760
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunkh
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
zerosnacks
reviewed
Jun 11, 2025
| @@ -16,7 +17,7 @@ jobs: | |||
| update: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: cachix/install-nix-action@v30 | |||
| - uses: DeterminateSystems/determinate-nix-action@v3 | |||
There was a problem hiding this comment.
Would you mind expanding on the need for this change?
There was a problem hiding this comment.
Sorry this PR should be good to review now but determinate nix in general is more stable and easier to work with. Not 100% necessary since this is just for updating flake lock but just to avoid any issues down the line especially since the update flake lock action is also by Determinate and is meant to work together.
|
@zerosnacks forgot to mark it as draft but should be ready to review and responded to comment |
zerosnacks
changed the base branch from
master
to
zerosnacks/test-fix-ci-build-nix
|
Going to merge this into a test branch so I can run it - thanks! |
zerosnacks
merged commit a4e8bbf
into
foundry-rs:zerosnacks/test-fix-ci-build-nix
22 checks passed
zerosnacks
added a commit
that referenced
this pull request
Jun 12, 2025
* fix: nix CI build (#10760) * update flake * try nix build * remove push from CI * Update flake.lock (#10766) flake.lock: Update Flake lock file updates: • Updated input 'fenix': 'github:nix-community/fenix/873cccc628f5e39407e319e6711f3b7d6d1f15cc?narHash=sha256-QD7e5WNVj4aWS5mlJZZnLJ6Lg0h5RSyyEFo2I6xBUEQ%3D' (2025-06-11) → 'github:nix-community/fenix/b8fda10da7629d856086bbc1e21164c2d55691e3?narHash=sha256-Jte1NonRzaKF6UpPL5FujKHVTVvc8CAIj8fK%2BX/0qVM%3D' (2025-06-12) • Updated input 'fenix/rust-analyzer-src': 'github:rust-lang/rust-analyzer/9c3476d225ccc90c081280c2a20e9f7d8a200325?narHash=sha256-R9vQiqez6Gm0ARJKgbsAeLyX493vwIaexOUAz0vDhak%3D' (2025-06-10) → 'github:rust-lang/rust-analyzer/5b2c8bc9ae90b4ad92dbeb7e52a7f5cbf5ba4d53?narHash=sha256-ewwoJOGE6sMnfXQkydmmjT6ixo1JetBZO0tDEENjOb8%3D' (2025-06-11) • Updated input 'nixpkgs': 'github:NixOS/nixpkgs/a12f3a99614894502e73eb816e9e076b0ab05730?narHash=sha256-DUVAe8E2X2QM0dAnTGlTiqemMqUMMyIeCH7UeNo0g64%3D' (2025-06-10) → 'github:NixOS/nixpkgs/f72be405a10668b8b00937b452f2145244103ebc?narHash=sha256-qX6gXVjaCXXbcn6A9eSLUf8Fm07MgPGe5ir3%2B%2By2O1Q%3D' (2025-06-11) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * make sure build runs on latest deps --------- Co-authored-by: Shaun <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist