Skip to content

feat: prefix local address with http scheme #6456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Nov 29, 2023

if 127.0.0.1:8545 is provided, the URL will be a file, resulting in obscure OS errors.

since this input is very common, like localhost, prefix it with http

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@mattsse mattsse merged commit 09a48f6 into foundry-rs:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants