fix cast call --trace when --block parameter is passed
#6673
Conversation
tonyke-bot
requested review from
DaniPopes,
Evalir and
mattsse
as code owners
| let evm_opts = figment.extract::<EvmOpts>()?; | ||
|
|
||
| config.fork_block_number = derive_fork_block_number(&provider, block).await?; |
There was a problem hiding this comment.
I'm not exactly sure about this,
I believe this should be set to evm_opts instead.
sorry this entire command is a bit messy...
There was a problem hiding this comment.
foundry/crates/evm/evm/src/executors/tracing.rs
Lines 36 to 39 in 67ab870
The fact is, inside get_fork_material(), evm_opts.fork_block_number is overridden with config.fork_block_number
There was a problem hiding this comment.
if it's overriden with the config block number then I think it's fine for now
|
ping |
| let evm_opts = figment.extract::<EvmOpts>()?; | ||
|
|
||
| config.fork_block_number = derive_fork_block_number(&provider, block).await?; |
There was a problem hiding this comment.
if it's overriden with the config block number then I think it's fine for now
|
Hi @tonyke-bot, thanks for your PR! Would you be interested in updating it to use Alloy? Would be great to get this fix in. |
|
@zerosnacks ack! |
|
Superseded by #8009 |
Motivation
When running
cast call --trace --block <block-number> <tx-hash>, theblockparameter doesn't work as expected. Latest block number is always used when sending RPC requests to pulling related information for local fork.This bug is confirmed by running the command with
RUST_LOG=traceto see the requests sent to RPC provider.Solution
Use the given
blockparameter to modify theconfig.fork_block_number. Whenblockis not a block number, convert to block number first.