fix: some verify-bytecode fixes #8513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up code a bit, removing redundant
Result
and preferring checkingmatch_type.is_none()
instead of keeping a separate bool.Also removes
--verification-type
flag as it doesn't make much sense because user'd expect us to determine match type during comparison.Closes #8505. The cause is etherscan bug - it returns invalid constructor arguments for mentioned contract.
I've updated logic to not rely on etherscan constructor args if
--constructor-args
are passed.Also updated
--constructor-args
to expect multiple values and abi-encode them similarly toforge create
as this seems to be the expected UX at least by the author of #8505. I've kept an option for abi-encoded args as--encoded-constructor-args